Skip to content

Conversation

@brianjmurrell
Copy link
Contributor

To facilitate building with mock allow specifying the mock "root" to build in.

Allow specifying the kernel version to build for.

@brianjmurrell
Copy link
Contributor Author

Licence-date-verification / verify-date (pull_request) Failing after 4s

Is this something I need to fix? Or is there a maintainer or otherwise automated action that will update this, either before or during landing?

@mmichal10
Copy link
Contributor

Hi @brianjmurrell

thanks for your contribution. We're currently on a tight schedule so it may take us some time to review your patch.

Regarding the licence check - each file in the project has a header with copyrights. The script checks if the license has been updated for each file modified in your pull request. You could refer e.g. to this contribution from the community on how to update the license

@brianjmurrell
Copy link
Contributor Author

Hi @brianjmurrell

thanks for your contribution. We're currently on a tight schedule so it may take us some time to review your patch.

Sure. At your convenience.

Regarding the licence check - each file in the project has a header with copyrights.

Indeed. We did much the same when I worked at Intel also.

The script checks if the license has been updated for each file modified in your pull request. You could refer e.g. to this contribution from the community on how to update the license

Ahh. Thanks. Nice example. I wasn't sure if your policies allowed contributors to add copyright or whether it was required to be signed over to your project/company. I will update per the example.

@rafalste
Copy link
Contributor

Hey @brianjmurrell,
I've updated your pull request to be more portable and better fit our package generator tool. The first difference you'll probably notice is to remove any env variables passing in Makefile. Those Makefile rules are just a shortcut for pckgen.sh tool that should be used directly in any more complicated scenarios than just creating basic package on current setup.
Feel free to check it out and post any comments.

Cheers!

@brianjmurrell
Copy link
Contributor Author

Changes look fine and work here in the tests I ran on them.

brianjmurrell and others added 4 commits August 27, 2025 13:25
To facilitate building with mock allow specifying the mock "root" to
build in.

Allow specifying the kernel version to build for.

Signed-off-by: Brian J. Murrell <brian@interlinx.bc.ca>
Signed-off-by: Rafal Stefanowski <rafal.stefanowski@huawei.com>
Signed-off-by: Rafal Stefanowski <rafal.stefanowski@huawei.com>
- add --kernel-version option
- add --mock option for 'mock' support to emulate building RPM packages
  on other distros to further improve choosing proper kernel version
- update dependencies

Signed-off-by: Rafal Stefanowski <rafal.stefanowski@huawei.com>
@rafalste rafalste force-pushed the build-rpm-with-mock branch from 20f872b to 0585797 Compare August 27, 2025 11:26
@brianjmurrell
Copy link
Contributor Author

Any further reviews required here or can this be landed?

@robertbaldyga robertbaldyga merged commit 3150c3f into Open-CAS:master Sep 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants